64-bit issue

[ardbiesheuvel]

Hi,

Thanks for creating RIp. I used to use EAC in a distant past, and I am very happy to see a tool for OSX that gives me an easy way to accurately rip my CDs to ALAC.

I noticed an issue with the accurate rip check on 64-bit.
It seems you are using a signed long to store the 32 bit AccurateRip digest, and on 64-bit, it is being sign extended resulting in a value like 0xffffffff87654321 if bit 31 is set (the sign bit).
This results in AccurateRip check fails where the check should actually succeed.

I fixed it for now by using lipo to strip the x86_64 slice from the Rip fat binary.
This time, the same CD that produced a number of 'copy verified' messages now show AccurateRip + confidence for all tracks.

Cheers,
Ard.

[sbooth]

Thank you for this report!

[nbhms]

ahhh, was about to post asking why I'm getting "copy verified" mixed in with tracks on the same CD with a high confidence level (22+), and spot checks of the "copy verified" tracks seemed to indicate they are fine. Since I'm on Mavericks I assume this is the issue?

Don't really want to start messing with the binaries, guess I'll just live with it.