Potential Tag issue

Discuss Tag, an open source metadata editor for audio files.
Post Reply
stokessd
Posts: 5
Joined: Sun Apr 16, 2006 7:11 pm

Potential Tag issue

Post by stokessd » Sun Apr 16, 2006 7:27 pm

I've ripped my collection of CD's t FLAC files using EAC and a raft of cd drives. I have been grooming the tags and such using a LabView application I wrote with is a wrapper around metaflac. I found max and tag and thought I'd give it a try. (I'm really close to being able to shed all my PC apps).

I tried to do a bulk rename of the artist name for an album

The original artist name was Block, Rory and I selected all files, changed the artist to Rory Block, and saved. I now get the following tags (using metaflac):

comment[0]: artist=Block, Rory
comment[1]: title=Angel of Mercy
comment[2]: album=Angel of Mercy
comment[3]: date=1994
comment[4]: tracknumber=01
comment[5]: genre=Blues
comment[6]: ARTIST=Rory Block


I have played with the preferences for both off and flac tags to try to get it to realize that the artist and ARTIST tags are really the same. I overrode the artist tag to be both small and uppercase "artist" and I can't seem to make it realize that it's got duplicate tags.

the duplicates by themselves don't matter as the slimserver uses the last tag, but this program (TAG) doesn't recognize the new ARTIST tag it added. I'm not sure this is a bug or a problem with my encoded files.

I'd love to use this program but until I figure out how to make it work with my flac files, I'll keep using my labview tagger that I wrote.

Sheldon

Here's a complete listing from metaflac:


METADATA block #0
type: 0 (STREAMINFO)
is last: false
length: 34
minumum blocksize: 4608 samples
maximum blocksize: 4608 samples
minimum framesize: 14 bytes
maximum framesize: 14598 bytes
sample_rate: 44100 Hz
channels: 2
bits-per-sample: 16
total samples: 11907000
MD5 signature: 222c95b7c18127b7335599bd238713f3
METADATA block #1
type: 3 (SEEKTABLE)
is last: false
length: 486
seek points: 27
point 0: sample_number=0, stream_offset=0, frame_samples=4608
point 1: sample_number=437760, stream_offset=894809, frame_samples=4608
point 2: sample_number=880128, stream_offset=1839619, frame_samples=4608
point 3: sample_number=1322496, stream_offset=2865350, frame_samples=4608
point 4: sample_number=1760256, stream_offset=3909229, frame_samples=4608
point 5: sample_number=2202624, stream_offset=4921126, frame_samples=4608
point 6: sample_number=2644992, stream_offset=6014227, frame_samples=4608
point 7: sample_number=3082752, stream_offset=7102149, frame_samples=4608
point 8: sample_number=3525120, stream_offset=8142621, frame_samples=4608
point 9: sample_number=3967488, stream_offset=9193342, frame_samples=4608
point 10: sample_number=4409856, stream_offset=10259203, frame_samples=4608
point 11: sample_number=4847616, stream_offset=11353916, frame_samples=4608
point 12: sample_number=5289984, stream_offset=12531265, frame_samples=4608
point 13: sample_number=5732352, stream_offset=13654118, frame_samples=4608
point 14: sample_number=6170112, stream_offset=14778241, frame_samples=4608
point 15: sample_number=6612480, stream_offset=15957050, frame_samples=4608
point 16: sample_number=7054848, stream_offset=17063494, frame_samples=4608
point 17: sample_number=7492608, stream_offset=18129008, frame_samples=4608
point 18: sample_number=7934976, stream_offset=19197004, frame_samples=4608
point 19: sample_number=8377344, stream_offset=20365327, frame_samples=4608
point 20: sample_number=8819712, stream_offset=21481776, frame_samples=4608
point 21: sample_number=9257472, stream_offset=22563948, frame_samples=4608
point 22: sample_number=9699840, stream_offset=23611848, frame_samples=4608
point 23: sample_number=10142208, stream_offset=24684352, frame_samples=4608
point 24: sample_number=10579968, stream_offset=25747742, frame_samples=4608
point 25: sample_number=11022336, stream_offset=26792631, frame_samples=4608
point 26: sample_number=11464704, stream_offset=27718758, frame_samples=4608
METADATA block #2
type: 4 (VORBIS_COMMENT)
is last: false
length: 177
vendor string: reference libFLAC 1.1.2 20050205
comments: 7
comment[0]: artist=Block, Rory
comment[1]: title=Angel of Mercy
comment[2]: album=Angel of Mercy
comment[3]: date=1994
comment[4]: tracknumber=01
comment[5]: genre=Blues
comment[6]: ARTIST=Rory Block
METADATA block #3
type: 1 (PADDING)
is last: true
length: 4075

User avatar
sbooth
Site Admin
Posts: 2445
Joined: Fri Dec 23, 2005 7:45 am
Location: USA
Contact:

Re: Potential Tag issue

Post by sbooth » Sun Apr 16, 2006 10:04 pm

stokessd wrote:The original artist name was Block, Rory and I selected all files, changed the artist to Rory Block, and saved. I now get the following tags (using metaflac):

comment[0]: artist=Block, Rory
comment[1]: title=Angel of Mercy
comment[2]: album=Angel of Mercy
comment[3]: date=1994
comment[4]: tracknumber=01
comment[5]: genre=Blues
comment[6]: ARTIST=Rory Block
Out of curiousity, did you change the artist using the Basic or Advanced tab? It shouldn't make a difference necessarily, but I wonder why Tag added an artist Tag instead of editing the pre-existing one.

Was the current artist displayed in the proper text field in the Basic view?
stokessd wrote:I have played with the preferences for both off and flac tags to try to get it to realize that the artist and ARTIST tags are really the same. I overrode the artist tag to be both small and uppercase "artist" and I can't seem to make it realize that it's got duplicate tags.
Tag should convert all field names to uppercase for comparison's sake- I will check the source and make sure this is how it is working. It is quite possibly a bug.

FWIW, per the vorbis specification there are truly no "duplicate" tags:
Field names are not required to be unique (occur once) within a comment header. As an example, assume a track was recorded by three well know artists; the following is permissible, and encouraged:
ARTIST=Dizzy Gillespie
ARTIST=Sonny Rollins
ARTIST=Sonny Stitt
stokessd wrote:the duplicates by themselves don't matter as the slimserver uses the last tag, but this program (TAG) doesn't recognize the new ARTIST tag it added. I'm not sure this is a bug or a problem with my encoded files.
I assume that when you open the FLAC with Tag, the old artist is displayed in the artist text field?

You might be able to remove the extraneous artist tag by selecting it in the advanced view and clicking the "-" button at the bottom.

stokessd
Posts: 5
Joined: Sun Apr 16, 2006 7:11 pm

Re: Potential Tag issue

Post by stokessd » Sat Apr 22, 2006 2:29 pm

sbooth wrote: Out of curiousity, did you change the artist using the Basic or Advanced tab? It shouldn't make a difference necessarily, but I wonder why Tag added an artist Tag instead of editing the pre-existing one.
I dragged a directory of flac files (one album) and dropped it on TAG, which opened the drawer and in the basic tab showed me <Multiple values> for the Title and the proper artist, album, year, etc fields. I was fixing a few artist names by album, so I used the basic tag to update the artist and hit save. Everything appeared to be working fine, the bold track names, unbolded after saving etc.

sbooth wrote: Was the current artist displayed in the proper text field in the Basic view?
No, that's the problem, is that the original (small case artist tag) was being shown in the basic window.

sbooth wrote: Tag should convert all field names to uppercase for comparison's sake- I will check the source and make sure this is how it is working. It is quite possibly a bug.
IF you need a couple FLAC files of mine that are acting up, I'll mail you a CD of them.
sbooth wrote: FWIW, per the vorbis specification there are truly no "duplicate" tags:
Field names are not required to be unique (occur once) within a comment header. As an example, assume a track was recorded by three well know artists; the following is permissible, and encouraged:
ARTIST=Dizzy Gillespie
ARTIST=Sonny Rollins
ARTIST=Sonny Stitt
True, there are no duplicates, when each tag is unique, but when there are a pair of them, saying the same thing, they are duplicates in my mind... :)

sbooth wrote: I assume that when you open the FLAC with Tag, the old artist is displayed in the artist text field?
That is correct, it ignores the second artist tag.
sbooth wrote: You might be able to remove the extraneous artist tag by selecting it in the advanced view and clicking the "-" button at the bottom.
No, It won't delete the first one, nothing happens when I hit the "-" on the original artist. I can remove the new artist tag with the "-" button.


Here's my FLAC generating method, FYI:

Rip CD's using EAC on Windows XP
EAC is using the latest stable FLAC encoder, and I'm using the latest metaflac to read the tags
Transfer the files to a Kurobox NAS using a samba share
The kurobox runs slimserver
I was editing the FLAC tags by mounting the SMB share on my mac.


hope that helps,
Sheldon

User avatar
sbooth
Site Admin
Posts: 2445
Joined: Fri Dec 23, 2005 7:45 am
Location: USA
Contact:

Post by sbooth » Sat Apr 22, 2006 4:28 pm

OK, I did a little investigation this morning and found the source of the problem. I wasn't converting field names to uppercase when the file was opened, which would lead to this behavior.

I have fixed the bug in svn and I plan on releasing a new version of Tag relatively soon (this weekend). If you need a development build before then please e-mail me.

Thanks for helping me track this down!

stokessd
Posts: 5
Joined: Sun Apr 16, 2006 7:11 pm

Post by stokessd » Sun Apr 23, 2006 1:36 am

sbooth wrote: Thanks for helping me track this down!
No problem, glad to do it.

do you have any immediate coding needs that I could help out with?

Sheldon

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest